Merge branch 'topic/fix_memoization_cache' into 'master'

Replace memoization cache map by a hash map

Closes #459

See merge request eng/libadalang/langkit-query-language!426

Author: HugoGGuerrier

lkql_jit/language/src/main/java/com/adacore/lkql_jit/nodes/root_nodes/MemoizedRootNode.java

@@ -8,7 +8,7 @@
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.TruffleLanguage;
 import com.oracle.truffle.api.frame.FrameDescriptor;
-import org.graalvm.collections.EconomicMap;
+import java.util.HashMap;
 
 /**
  * This root node is the base of all root node which can be memoized in LKQL.
@@ -19,8 +19,13 @@ public abstract class MemoizedRootNode<K, V> extends BaseRootNode {
 
     // ----- Attributes -----
 
-    /** Cache to store the root node execution results. */
-    protected final EconomicMap<K, V> memoizationCache;
+    /**
+     * Cache to store the root node execution results.
+     *
+     * IMPORTANT: We don't use the {@link org.graalvm.collections.EconomicMap} class to represent
+     * the cache because there is an implementation error causing invalid cache hits.
+     */
+    protected final HashMap<K, V> memoizationCache;
 
     // ----- Constructors -----
 
@@ -35,7 +40,7 @@ protected MemoizedRootNode(
         final FrameDescriptor frameDescriptor
     ) {
         super(language, frameDescriptor);
-        this.memoizationCache = EconomicMap.create();
+        this.memoizationCache = new HashMap<>();
     }
 
     // ----- Instance methods -----
@@ -59,7 +64,7 @@ protected boolean isMemoized(final K key) {
      */
     @CompilerDirectives.TruffleBoundary
     protected V getMemoized(final K key) {
-        return this.memoizationCache.get(key, null);
+        return this.memoizationCache.get(key);
     }
 
     /**