Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging Feature #546

Open
mosaleh-dev opened this issue Mar 9, 2024 · 0 comments
Open

Tagging Feature #546

mosaleh-dev opened this issue Mar 9, 2024 · 0 comments

Comments

@mosaleh-dev
Copy link

mosaleh-dev commented Mar 9, 2024

I've created a Proof of Concept (POC) for tagging, which has proven to be very helpful for my use cases. I would like to contribute this feature by submitting a pull request (PR), but I have several questions:
POC.webm

  • Should offline tagging be implemented for the stopwatch watcher or another custom watcher?
  • Should it be integrated into the timeline view, or should there be a separate view specifically for offline tagging?
  • Regarding the refetching of events in the eventEditor component, I am currently passing an edited event to the eventEditor. Is there a case that I am not aware of that necessitates refetching events?
  • How should I implement this feature to ensure it is included in the next stable release?

Note: Currently, I am triggering a re-render to update the graph, which is causing a delay. I understand that this should be optimized, and I am open to suggestions for improvement.

Additionally, I'd like to mention that this would be my first real contribution to the project. I appreciate any guidance and support from the community.
Related: ActivityWatch/activitywatch#95

@mosaleh-dev mosaleh-dev changed the title Offline Tagging Feature Tagging Feature Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant