Merge branch 'Acode-Foundation:main' into codemirror

Author: bajrangCoder

src/components/terminal/terminalDefaults.js

@@ -14,6 +14,7 @@ export const DEFAULT_TERMINAL_SETTINGS = {
 	letterSpacing: 0,
 	imageSupport: false,
 	fontLigatures: false,
+	confirmTabClose: true,
 	// Touch selection settings
 	touchSelectionTapHoldDuration: 600,
 	touchSelectionMoveThreshold: 8,

src/components/terminal/terminalManager.js

@@ -7,6 +7,8 @@ import EditorFile from "lib/editorFile";
 import TerminalComponent from "./terminal";
 import "@xterm/xterm/css/xterm.css";
 import toast from "components/toast";
+import confirm from "dialogs/confirm";
+import appSettings from "lib/settings";
 import helpers from "utils/helpers";
 
 const TERMINAL_SESSION_STORAGE_KEY = "acodeTerminalSessions";
@@ -413,6 +415,22 @@ class TerminalManager {
 			this.closeTerminal(terminalId);
 		};
 
+		terminalFile._skipTerminalCloseConfirm = false;
+		const originalRemove = terminalFile.remove.bind(terminalFile);
+		terminalFile.remove = async (force = false) => {
+			if (
+				!terminalFile._skipTerminalCloseConfirm &&
+				this.shouldConfirmTerminalClose()
+			) {
+				const message = `${strings["close"]} ${strings["terminal"]}?`;
+				const shouldClose = await confirm(strings["confirm"], message);
+				if (!shouldClose) return;
+			}
+
+			terminalFile._skipTerminalCloseConfirm = false;
+			return originalRemove(force);
+		};
+
 		// Enhanced resize handling with debouncing
 		let resizeTimeout = null;
 		const RESIZE_DEBOUNCE = 200;
@@ -519,6 +537,7 @@ class TerminalManager {
 			}
 
 			this.closeTerminal(terminalId);
+			terminalFile._skipTerminalCloseConfirm = true;
 			terminalFile.remove(true);
 			toast(message);
 		};
@@ -731,6 +750,14 @@ class TerminalManager {
 			}
 		});
 	}
+
+	shouldConfirmTerminalClose() {
+		const settings = appSettings?.value?.terminalSettings;
+		if (settings && settings.confirmTabClose === false) {
+			return false;
+		}
+		return true;
+	}
 }
 
 // Create singleton instance

src/lang/hu-hu.json

@@ -256,9 +256,9 @@
 	"find file": "Fájl keresése",
 	"system": "Rendszer",
 	"please select a formatter": "Válasszon formátumkészítőt",
-	"case sensitive": "Nagy-/kisbetű érzékeny",
-	"regular expression": "Reguláris kifejezés",
-	"whole word": "Egész szó",
+	"case sensitive": "Kis- és nagybetűk megkülönböztetése",
+	"regular expression": "Reguláris kifejezések",
+	"whole word": "Illesztés csak teljes szóra",
 	"edit with": "Szerkesztés ezzel",
 	"open with": "Megnyitás ezzel",
 	"no app found to handle this file": "Nem található alkalmazás a fájl kezelésére",

src/pages/fileBrowser/fileBrowser.js

@@ -1333,14 +1333,16 @@ function FileBrowserInclude(mode, info, doesOpenLast = true) {
 		 * @param {String} url
 		 */
 		function pushToNavbar(name, url, action) {
+			if (!url) return;
+			const displayName = name || Url.basename(url) || url;
 			$navigation.append(
 				<span
 					id={getNavId(url)}
 					className="nav"
 					data-url={url}
-					data-name={name}
+					data-name={displayName}
 					attr-action="navigation"
-					attr-text={name}
+					attr-text={displayName}
 					tabIndex={-1}
 				></span>,
 			);
@@ -1359,14 +1361,20 @@ function FileBrowserInclude(mode, info, doesOpenLast = true) {
 		 * @param {Array<Location>} states
 		 */
 		function loadStates(states) {
-			if (!Array.isArray(states)) return;
+			if (!Array.isArray(states) || !states.length) return;
 
 			const backNavigation = [];
-			const { url, name } = states.pop();
+			const lastState = states.pop();
+			if (!lastState || !lastState.url) return;
+			const { url } = lastState;
+			const name = lastState.name || Url.basename(url) || url;
 			let { url: lastUrl, name: lastName } = currentDir;
 
 			while (states.length) {
 				const location = states.splice(0, 1)[0];
+				if (!location || !location.url) {
+					continue;
+				}
 				const { url, name } = location;
 				let action;
 

src/plugins/system/android/com/foxdebug/system/System.java

@@ -691,14 +691,29 @@ private void hasPermission(String permission, CallbackContext callback) {
     }
 
     public boolean fileExists(String path, String countSymlinks) {
-        Path p = new File(path).toPath();
+        boolean followSymlinks = !Boolean.parseBoolean(countSymlinks);
+        File file = new File(path);
+
+        // Android < O does not implement File#toPath(), fall back to legacy checks
+        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.O) {
+            if (!file.exists()) return false;
+            if (followSymlinks) {
+                try {
+                    // If canonical and absolute paths differ, it's a symlink
+                    return file.getCanonicalPath().equals(file.getAbsolutePath());
+                } catch (IOException ignored) {
+                    return false;
+                }
+            }
+            return true;
+        }
+
+        Path p = file.toPath();
         try {
-            if (Boolean.parseBoolean(countSymlinks)) {
-                // This will return true even for broken symlinks
-                return Files.exists(p, LinkOption.NOFOLLOW_LINKS);
-            } else {
-                // Check target file, not symlink itself
+            if (followSymlinks) {
                 return Files.exists(p) && !Files.isSymbolicLink(p);
+            } else {
+                return Files.exists(p, LinkOption.NOFOLLOW_LINKS);
             }
         } catch (Exception e) {
             return false;
@@ -1301,4 +1316,4 @@ private void setInputType(String type) {
         }
         webView.setInputType(mode);
     }
-}
+}

src/plugins/websocket/www/websocket.js

@@ -58,13 +58,21 @@ class WebSocketInstance extends EventTarget {
 
             if (event.type === 'close') {
                 this.readyState = WebSocketInstance.CLOSED;
-                const closeEvent = new CloseEvent('close', { code: event.data?.code, reason: event.data?.reason });
+                const closeData = event && event.data ? event.data : {};
+                const closeEvent = new CloseEvent('close', {
+                    code: closeData.code,
+                    reason: closeData.reason,
+                });
                 if (this.onclose) this.onclose(closeEvent);
                 this.dispatchEvent(closeEvent);
             }
 
             if (event.type === 'error') {
-                const errorEvent = new Event('error', { message: event?.data });
+                const errorMessage = event && event.data ? event.data : undefined;
+                const errorEvent = new Event('error');
+                if (errorMessage !== undefined) {
+                    errorEvent.message = errorMessage;
+                }
                 if (this.onerror) this.onerror(errorEvent);
                 this.dispatchEvent(errorEvent);
             }

src/settings/terminalSettings.js

@@ -165,6 +165,12 @@ export default function terminalSettings() {
 			checkbox: terminalValues.fontLigatures,
 			info: "Whether font ligatures are enabled in the terminal.",
 		},
+		{
+			key: "confirmTabClose",
+			text: `${strings["confirm"]} ${strings["terminal"]} tab close`,
+			checkbox: terminalValues.confirmTabClose !== false,
+			info: "Ask for confirmation before closing terminal tabs.",
+		},
 		{
 			key: "backup",
 			text: strings.backup.capitalize(),

www/index.html

@@ -47,7 +47,7 @@
       type,
       listener,
       useCapture,
-      allowed,
+      allowed
     ) {
       if (typeof useCapture === "boolean") {
         allowed = useCapture;
@@ -76,7 +76,7 @@
         }
         this.eventListeners[type].push({
           listener: listener,
-          useCapture: useCapture,
+          useCapture: useCapture
         });
 
         return;
@@ -159,4 +159,4 @@
   <wc-page id="root" class="primary"></wc-page>
 </body>
 
-</html>
+</html>