From 34fd37e3fcf5a898ecf409d1d19720efce84dcc0 Mon Sep 17 00:00:00 2001 From: Diego Tavares Date: Tue, 28 Jan 2025 14:16:38 -0800 Subject: [PATCH] [cuegui] Remove check for source waiting frames on redirect (#1648) Checking for if the source job has waiting frames makes no sense as the job is giving up its resources. This unnecessary check was preventing operations from redirecting resources from jobs that were fully booked but still running. --- cuegui/cuegui/Redirect.py | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/cuegui/cuegui/Redirect.py b/cuegui/cuegui/Redirect.py index 1922e49c0..b7e60fcb5 100644 --- a/cuegui/cuegui/Redirect.py +++ b/cuegui/cuegui/Redirect.py @@ -604,7 +604,7 @@ def __isBurstSafe(self, alloc, procs, show): @classmethod def __isAllowed(cls, procs, targetJob): """Checks if the follow criteria are met to allow redirect to target job: - - if source/target job have waiting frames + - if target job have waiting frames - if target job hasn't reached maximum cores - check if adding frames will push target job over it's max cores @@ -627,19 +627,10 @@ def __isAllowed(cls, procs, targetJob): targetJob.maxCores()) # Case 2: 1. Check target job for waiting frames - # 2. Check source procs for waiting frames if allowed and targetJob.waitingFrames() <= 0: allowed = False errMsg = "Target job %s has no waiting frames" % targetJob.name() - if allowed: - for proc in procs: - job = proc.getJob() - if job.waitingFrames() <= 0: - allowed = False - errMsg = "Source job %s has no waiting frames" % job.name() - break - # Case 3: Check if each proc or summed up procs will # push targetJob over it's max cores if allowed: