Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ButtonDef is bad abstraction #159

Open
DarthGandalf opened this issue Dec 15, 2023 · 0 comments
Open

ButtonDef is bad abstraction #159

DarthGandalf opened this issue Dec 15, 2023 · 0 comments

Comments

@DarthGandalf
Copy link
Contributor

  1. It requires a filename of the image. This means that I need to load the image twice: to query the size of the frame, and to actually show it on screen.
  2. Far from every button has text/font, but ButtonDef requires it

Related: Button should be decoupled from "clickable area". Examples of non-button clickable areas are tabs in quests/waypoints panels, helmet/amulet/etc slots in inventory. Mouse handling isn't specific to Buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DarthGandalf