fix: resolve review comments

Author: dalechyn

packages/core/src/actions/account/public/get-total-value.ts

@@ -20,5 +20,6 @@ export async function getTotalValue({
     },
   })
   const res = await proxyQueryClient.totalValue()
+  // @TODO: might overflow a number
   return +res.total_value
 }

packages/core/src/actions/account/wallet/remove-namespace.ts

@@ -4,19 +4,19 @@ import { WithArgsAndCosmWasmSignOptions } from '../../../types/with-args'
 import { getVersionControlClientFromApi } from '../../wallet/get-version-control-client-from-api'
 import { getNamespace } from '../public/get-namespace'
 
-export type RemoveNamespaceParameters = WithArgsAndCosmWasmSignOptions<{
+export type RevokeNamespaceParameters = WithArgsAndCosmWasmSignOptions<{
   accountId: VersionControlTypes.AccountId
   signingCosmWasmClient: SigningCosmWasmClient
   apiUrl: string
   sender: string
 }>
 
-export async function removeNamespace({
+export async function revokeNamespace({
   args: { accountId, signingCosmWasmClient, apiUrl, sender },
   fee,
   memo,
   funds,
-}: RemoveNamespaceParameters) {
+}: RevokeNamespaceParameters) {
   const versionControlClient = await getVersionControlClientFromApi({
     args: {
       signingCosmWasmClient,

packages/core/src/actions/get-version-control-address-from-api.ts

@@ -14,13 +14,9 @@ export async function getVersionControlAddressFromApi({
     apiUrl,
     gql(/* GraphQL */ `
       query VersionControlDeployment($chain: ID!) {
-        version
         deployment(chain: $chain) {
           registry
         }
-        chainInfo(chain: $chain) {
-          rpcUrl
-        }
       }
     `),
     {

packages/core/src/actions/public/get-abstract-module-address-from-version-control.ts

@@ -27,7 +27,7 @@ export async function getAbstractModuleAddressFromVersionControl({
     },
   })
 
-  const [accountFactoryAddress] = await versionControlQueryClient
+  const [moduleAddress] = await versionControlQueryClient
     .modules({
       infos: [
         {
@@ -41,11 +41,11 @@ export async function getAbstractModuleAddressFromVersionControl({
       modules.map(({ module }) => versionControlModuleToAddress(module)),
     )
 
-  if (!accountFactoryAddress) {
+  if (!moduleAddress) {
     throw new Error(
       `Could not fetch address for module ${moduleName} version ${version} from registry ${versionControlAddress}`,
     )
   }
 
-  return accountFactoryAddress
+  return moduleAddress
 }

packages/core/src/clients/decorators/account-wallet.ts

@@ -5,7 +5,7 @@ import { deposit } from '../../actions/account/wallet/deposit'
 import { execute } from '../../actions/account/wallet/execute'
 import { getManagerClientFromApi } from '../../actions/account/wallet/get-manager-client-from-api'
 import { getProxyClientFromApi } from '../../actions/account/wallet/get-proxy-client-from-api'
-import { removeNamespace } from '../../actions/account/wallet/remove-namespace'
+import { revokeNamespace } from '../../actions/account/wallet/remove-namespace'
 import { withdraw } from '../../actions/account/wallet/withdraw'
 import { VersionControlTypes } from '../../codegen/abstract/index'
 import { CutArgs } from '../../types/with-args'
@@ -39,9 +39,9 @@ export type AccountWalletActions = {
   getProxyClientFromApi(
     args: CutSpecificArgsFromParameter<typeof getProxyClientFromApi>,
   ): ReturnType<typeof getProxyClientFromApi>
-  removeNamespace(
-    args: CutSpecificArgsFromParameter<typeof removeNamespace>,
-  ): ReturnType<typeof removeNamespace>
+  revokeNamespace(
+    args: CutSpecificArgsFromParameter<typeof revokeNamespace>,
+  ): ReturnType<typeof revokeNamespace>
   withdraw(
     args: CutSpecificArgsFromParameter<typeof withdraw>,
   ): ReturnType<typeof withdraw>
@@ -89,8 +89,8 @@ export function accountWalletActions(
         args: { ...args, accountId, signingCosmWasmClient, apiUrl, sender },
         ...rest,
       }),
-    removeNamespace: ({ args, ...rest }) =>
-      removeNamespace({
+    revokeNamespace: ({ args, ...rest }) =>
+      revokeNamespace({
         args: { ...args, accountId, signingCosmWasmClient, apiUrl, sender },
         ...rest,
       }),