Skip to content

Commit b3a9f66

Browse files
Merge pull request awslabs#281 from alex-chew/fix-asset-uploader-error-logging
Fix some asset uploader error cases
2 parents 9a4a214 + 0c0e317 commit b3a9f66

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

lambdas/static-asset-uploader/index.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,9 @@ function cleanS3Bucket(bucketName) {
185185
function createCatalogDirectory(staticBucketName) {
186186
let params = { Bucket: staticBucketName, Key: 'catalog/', Body: '' }
187187
return exports.s3.upload(params).promise()
188+
.catch(err => {
189+
console.log('Error creating "catalog" directory', err)
190+
})
188191
}
189192

190193
/**
@@ -195,11 +198,11 @@ function createCatalogDirectory(staticBucketName) {
195198
*/
196199
async function createSdkGenerationFile(staticBucketName) {
197200
return await exports.s3.headObject({ Bucket: staticBucketName, Key: 'sdkGeneration.json' }).promise()
198-
.catch((error) => {
199-
console.error(error)
201+
.catch(async _error => {
200202
// assume it's a NotFound error, and upload a new version
203+
console.log('Uploading sdkGeneration.json since it seems to not exist')
201204
let params = { Bucket: staticBucketName, Key: 'sdkGeneration.json', Body: '{}' }
202-
return exports.s3.upload(params).promise()
205+
return await exports.s3.upload(params).promise()
203206
})
204207

205208
}
@@ -255,7 +258,8 @@ function processFile(fileStat, readPromises, uploadPromises, bucketName, event,
255258
params.ACL = "public-read"
256259
}
257260

258-
uploadPromises.push(exports.s3.upload(params, options).promise())
261+
uploadPromises.push(exports.s3.upload(params, options).promise()
262+
.catch(err => { throw err }))
259263
})
260264
.catch(error => {
261265
console.log(`Failed to upload:`, error)

0 commit comments

Comments
 (0)