added plan + fixed usage reports (always include)

Author: g10

src/authorize_response.coffee

@@ -22,10 +22,13 @@ class AuthorizeResponse extends Response
 
 	constructor: (@usage_reports) ->
 		@usage_reports = []
+		@plan = null
 
 
 	add_usage_reports: (options) ->
 		@usage_reports.push new UsageReport options
+
+	set_plan: (@plan) ->
 
 
 module.exports = exports = AuthorizeResponse

src/client.coffee

@@ -352,14 +352,15 @@ module.exports = class Client
       response = new AuthorizeResponse()
       authorize = doc.status.authorized
       plan = doc.status.plan
+      usage_reports = doc.status.usage_reports
 
       if authorize is 'true'
         response.success(status_code)
       else
         reason = doc.status.reason
         response.error(status_code, reason)
 
-        usage_reports = doc.status.usage_reports
+      response.set_plan plan
 
       if usage_reports
         for index, usage_report of usage_reports
@@ -375,6 +376,7 @@ module.exports = class Client
               report.period_end   = usage_report.period_end
 
             response.add_usage_reports report
+
       callback(response)
 
   _build_error_response: (status_code, xml, callback) ->

test/authorize_response_test.coffee

@@ -21,3 +21,14 @@ describe 'Basic test for the 3Scale::AuthorizeResponse', ->
       assert.equal authorize_response.usage_reports.length, 0
       authorize_response.add_usage_reports usage_report_options
       assert.equal authorize_response.usage_reports.length, 1
+
+    it 'should have a set_plan method', ->
+      authorize_response = new AuthorizeResponse()
+      assert.equal typeof authorize_response.set_plan, 'function'
+
+    it 'should be able to set a plan', ->
+      authorize_response = new AuthorizeResponse()
+      assert.equal authorize_response.plan, null
+      plan = 'Ultimate'
+      authorize_response.set_plan plan
+      assert.equal authorize_response.plan, plan

test/usage_report_test.coffee

@@ -5,6 +5,37 @@ Client = require('../src/client')
 
 describe 'Usage report tests for 3Scale::Client', ->
   it 'should parse the response of the Authorize call', (done) ->
+    xml_body = "<status>\
+                  <authorized>true</authorized>\
+                  <plan>Ultimate</plan>\
+                  <usage_reports>\
+                    <usage_report metric=\"hits\" period=\"day\" exceeded=\"false\">\
+                      <period_start>2010-04-26 00:00:00 +0000</period_start>\
+                      <period_end>2010-04-27 00:00:00 +0000</period_end>\
+                      <current_value>10002</current_value>\
+                      <max_value>50000</max_value>\
+                    </usage_report>\
+                  </usage_reports>\
+                </status>"
+
+    nock('https://su1.3scale.net')
+      .get('/transactions/authorize.xml?app_id=foo&provider_key=1234abcd')
+      .reply(200, xml_body, { 'Content-Type': 'application/xml' })
+
+    client = new Client '1234abcd'
+    client.authorize { app_id: 'foo' }, (response) ->
+      assert.equal response.is_success(), true
+      assert.equal response.status_code, 200
+      assert.equal response.plan, 'Ultimate'
+      assert.equal response.usage_reports[0].metric, 'hits'
+      assert.equal response.usage_reports[0].period, 'day'
+      assert.equal response.usage_reports[0].period_start, '2010-04-26 00:00:00 +0000'
+      assert.equal response.usage_reports[0].period_end, '2010-04-27 00:00:00 +0000'
+      assert.equal response.usage_reports[0].current_value, '10002'
+      assert.equal response.usage_reports[0].max_value, '50000'
+      done()
+      
+  it 'should parse the response of the Authorize call, when limit is exceeded', (done) ->
     xml_body = "<status>\
                   <authorized>false</authorized>\
                   <reason>usage limits are exceeded</reason>\
@@ -28,6 +59,7 @@ describe 'Usage report tests for 3Scale::Client', ->
       assert.equal response.is_success(), false
       assert.equal response.status_code, 409
       assert.equal response.error_message, 'usage limits are exceeded'
+      assert.equal response.plan, 'Ultimate'
       assert.equal response.usage_reports[0].metric, 'hits'
       assert.equal response.usage_reports[0].period, 'day'
       assert.equal response.usage_reports[0].period_start, '2010-04-26 00:00:00 +0000'
@@ -58,6 +90,7 @@ describe 'Usage report tests for 3Scale::Client', ->
       assert.equal response.is_success(), false
       assert.equal response.status_code, 409
       assert.equal response.error_message, 'usage limits are exceeded'
+      assert.equal response.plan, 'Ultimate'
       assert.equal response.usage_reports[0].metric, 'hits'
       assert.equal response.usage_reports[0].period, 'eternity'
       assert.equal response.usage_reports[0].period_start, undefined