fix(TextureIGListKitExtensions): guard viewForSupplementaryElementOfKind against stale section indices#13
Merged
Conversation
…ind against stale section indices After performUpdates reduces the section count, UICollectionView may still hold cached layout attributes for removed sections and request supplementary views for them during the next layout pass. Without a guard, the bridge forwards to IGListAdapter which throws NSInternalInconsistencyException because the section controller at that index is nil. Add a sectionController(forSection:) nil-check before forwarding to IGListAdapter in the viewForSupplementaryElementOfKind:atIndexPath: Interop forwarder. When the section is out of range, return a zero-size UICollectionReusableView placeholder that satisfies UIKit without crashing. Add a regression test that calls the bridge selector directly with a section index that was removed by a preceding performUpdates — verifying the placeholder path is taken instead of crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
performUpdatesreduces the section count, UICollectionView may still hold cached layout attributes for removed sections and request supplementary views for them in a subsequent layout passIGListAdapterwhich throwsNSInternalInconsistencyExceptionbecausesectionControllerat that index isnilsectionController(forSection:)nil-check before forwarding in theviewForSupplementaryElementOfKind:atIndexPath:Interop forwarder — returns a zero-sizeUICollectionReusableViewplaceholder when the section is stale