Merge pull request #7 from 123inkt/enable-checks-and-fix-issues

Enabled checks in github actions

Author: frankdekker

.github/workflows/test.yml

@@ -1,4 +1,4 @@
-name: Run tests
+name: Run checks
 
 on:
   push:
@@ -7,21 +7,35 @@ on:
     branches: [ master ]
 
 jobs:
-  build:
-    name: PHP ${{ matrix.php-versions }} Test
+  test:
+    name: PHP ${{ matrix.php-versions }} Test ${{ matrix.composer-flags }}
     runs-on: ubuntu-latest
     strategy:
       matrix:
         php-versions: ['7.1', '7.2', '7.3']
+        composer-flags: ['', '--prefer-lowest']
     steps:
-    - uses: actions/checkout@v2
-    - name: Setup PHP
-      uses: shivammathur/setup-php@v2
-      with:
-        php-version: ${{ matrix.php-versions }}
-    - name: Validate composer.json and composer.lock
-      run: composer validate
-    - name: Install dependencies
-      run: composer install --prefer-dist --no-progress --no-suggest
-    - name: Run test suite
-      run: composer test
+      - uses: actions/checkout@v2
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php-versions }}
+      - name: Validate composer.json and composer.lock
+        run: composer validate
+      - name: Install dependencies
+        run: composer update --prefer-dist --no-progress --no-suggest --prefer-stable ${{ matrix.composer-flags }}
+      - name: Run test suite
+        run: composer test
+  quality:
+    name: Quality checks
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 7.1
+      - name: Install dependencies
+        run: composer install --prefer-dist --no-progress --no-suggest
+      - name: run checks
+        run: composer check

src/Renderer/ViolationListRenderer.php

@@ -9,9 +9,12 @@
 
 class ViolationListRenderer
 {
-    /** @var ConstraintViolationListInterface */
+    /** @var ConstraintViolationListInterface<ConstraintViolationInterface> */
     private $violationList;
 
+    /**
+     * @param ConstraintViolationListInterface<ConstraintViolationInterface> $violations
+     */
     public function __construct(ConstraintViolationListInterface $violations)
     {
         $this->violationList = $violations;