Ignore EIP1271 validation for config updates. Signer may not be deployed

Author: ScreamingHawk

packages/account/src/account.ts

@@ -520,7 +520,7 @@ export class Account {
   async publishWitness(chainId: ethers.BigNumberish = 0, referenceChainId?: ethers.BigNumberish): Promise<void> {
     const digest = ethers.id(`This is a Sequence account woo! ${Date.now()}`)
     // Apply ERC-6492 to undeployed children
-    const signature = await this.signDigest(digest, 0, false, 'ignore', {referenceChainId, cantValidateBehavior: "eip6492"})
+    const signature = await this.signDigest(digest, 0, false, 'ignore', {chainId, referenceChainId, cantValidateBehavior: "eip6492"})
     const decoded = this.coders.signature.decode(signature)
     const recovered = await this.coders.signature.recover(decoded, { digest, chainId, address: this.address })
     const signatures = this.coders.signature.signaturesOf(recovered.config)
@@ -669,7 +669,8 @@ export class Account {
     await this.tracker.savePresignedConfiguration({
       wallet: this.address,
       nextConfig: config,
-      signature
+      signature,
+      validateBehavior: 'ignore'
     })
 
     // safety check, tracker should have a reverse lookup for the imageHash

packages/api/src/api.gen.ts

@@ -1,7 +1,7 @@
 /* eslint-disable */
-// sequence-api v0.4.0 470a0f88ea399c2a57ff8c22da54358c033ed5f0
+// sequence-api v0.4.0 bbe47e0331a18438fe5f7fe590a4b7b4e5102738
 // --
-// Code generated by webrpc-gen@v0.18.7 with typescript generator. DO NOT EDIT.
+// Code generated by webrpc-gen@v0.20.3 with typescript generator. DO NOT EDIT.
 //
 // webrpc-gen -schema=api.ridl -target=typescript -client -out=./clients/api.gen.ts
 
@@ -12,7 +12,7 @@ export const WebRPCVersion = 'v1'
 export const WebRPCSchemaVersion = 'v0.4.0'
 
 // Schema hash generated from your RIDL schema
-export const WebRPCSchemaHash = '470a0f88ea399c2a57ff8c22da54358c033ed5f0'
+export const WebRPCSchemaHash = 'bbe47e0331a18438fe5f7fe590a4b7b4e5102738'
 
 //
 // Types
@@ -78,6 +78,12 @@ export interface SequenceContext {
   utils: string
 }
 
+export interface PublicKey {
+  id: string
+  x: string
+  y: string
+}
+
 export interface User {
   address: string
   username: string
@@ -362,7 +368,7 @@ export interface SwapPrice {
   currencyAddress: string
   currencyBalance: string
   price: string
-  to: string
+  maxPrice: string
   transactionValue: string
 }
 
@@ -445,6 +451,8 @@ export interface API {
     headers?: object,
     signal?: AbortSignal
   ): Promise<SendPasswordlessLinkReturn>
+  registerPublicKey(args: RegisterPublicKeyArgs, headers?: object, signal?: AbortSignal): Promise<RegisterPublicKeyReturn>
+  getPublicKey(args: GetPublicKeyArgs, headers?: object, signal?: AbortSignal): Promise<GetPublicKeyReturn>
   friendList(args: FriendListArgs, headers?: object, signal?: AbortSignal): Promise<FriendListReturn>
   getFriendByAddress(args: GetFriendByAddressArgs, headers?: object, signal?: AbortSignal): Promise<GetFriendByAddressReturn>
   searchFriends(args: SearchFriendsArgs, headers?: object, signal?: AbortSignal): Promise<SearchFriendsReturn>
@@ -539,6 +547,7 @@ export interface API {
     headers?: object,
     signal?: AbortSignal
   ): Promise<ValidateWaaSVerificationNonceReturn>
+  getSwapPrice(args: GetSwapPriceArgs, headers?: object, signal?: AbortSignal): Promise<GetSwapPriceReturn>
   getSwapPrices(args: GetSwapPricesArgs, headers?: object, signal?: AbortSignal): Promise<GetSwapPricesReturn>
   getSwapQuote(args: GetSwapQuoteArgs, headers?: object, signal?: AbortSignal): Promise<GetSwapQuoteReturn>
   listCurrencyGroups(headers?: object, signal?: AbortSignal): Promise<ListCurrencyGroupsReturn>
@@ -635,6 +644,20 @@ export interface SendPasswordlessLinkArgs {
 export interface SendPasswordlessLinkReturn {
   status: boolean
 }
+export interface RegisterPublicKeyArgs {
+  publicKey: PublicKey
+}
+
+export interface RegisterPublicKeyReturn {
+  status: boolean
+}
+export interface GetPublicKeyArgs {
+  id: string
+}
+
+export interface GetPublicKeyReturn {
+  publicKey: PublicKey
+}
 export interface FriendListArgs {
   nickname?: string
   page?: Page
@@ -971,8 +994,6 @@ export interface RemoveLinkedWalletArgs {
   parentWalletMessage: string
   parentWalletSignature: string
   linkedWalletAddress: string
-  linkedWalletMessage: string
-  linkedWalletSignature: string
   signatureChainId: string
 }
 
@@ -997,11 +1018,23 @@ export interface ValidateWaaSVerificationNonceArgs {
 export interface ValidateWaaSVerificationNonceReturn {
   walletAddress: string
 }
+export interface GetSwapPriceArgs {
+  buyCurrencyAddress: string
+  sellCurrencyAddress: string
+  buyAmount: string
+  chainId: number
+  slippagePercentage?: number
+}
+
+export interface GetSwapPriceReturn {
+  swapPrice: SwapPrice
+}
 export interface GetSwapPricesArgs {
   userAddress: string
   buyCurrencyAddress: string
   buyAmount: string
   chainId: number
+  slippagePercentage?: number
 }
 
 export interface GetSwapPricesReturn {
@@ -1014,6 +1047,7 @@ export interface GetSwapQuoteArgs {
   buyAmount: string
   chainId: number
   includeApprove: boolean
+  slippagePercentage?: number
 }
 
 export interface GetSwapQuoteReturn {
@@ -1086,7 +1120,7 @@ export class API implements API {
   protected path = '/rpc/API/'
 
   constructor(hostname: string, fetch: Fetch) {
-    this.hostname = hostname
+    this.hostname = hostname.replace(/\/*$/, '')
     this.fetch = (input: RequestInfo, init?: RequestInit) => fetch(input, init)
   }
 
@@ -1224,6 +1258,36 @@ export class API implements API {
     )
   }
 
+  registerPublicKey = (args: RegisterPublicKeyArgs, headers?: object, signal?: AbortSignal): Promise<RegisterPublicKeyReturn> => {
+    return this.fetch(this.url('RegisterPublicKey'), createHTTPRequest(args, headers, signal)).then(
+      res => {
+        return buildResponse(res).then(_data => {
+          return {
+            status: <boolean>_data.status
+          }
+        })
+      },
+      error => {
+        throw WebrpcRequestFailedError.new({ cause: `fetch(): ${error.message || ''}` })
+      }
+    )
+  }
+
+  getPublicKey = (args: GetPublicKeyArgs, headers?: object, signal?: AbortSignal): Promise<GetPublicKeyReturn> => {
+    return this.fetch(this.url('GetPublicKey'), createHTTPRequest(args, headers, signal)).then(
+      res => {
+        return buildResponse(res).then(_data => {
+          return {
+            publicKey: <PublicKey>_data.publicKey
+          }
+        })
+      },
+      error => {
+        throw WebrpcRequestFailedError.new({ cause: `fetch(): ${error.message || ''}` })
+      }
+    )
+  }
+
   friendList = (args: FriendListArgs, headers?: object, signal?: AbortSignal): Promise<FriendListReturn> => {
     return this.fetch(this.url('FriendList'), createHTTPRequest(args, headers, signal)).then(
       res => {
@@ -1999,6 +2063,21 @@ export class API implements API {
     )
   }
 
+  getSwapPrice = (args: GetSwapPriceArgs, headers?: object, signal?: AbortSignal): Promise<GetSwapPriceReturn> => {
+    return this.fetch(this.url('GetSwapPrice'), createHTTPRequest(args, headers, signal)).then(
+      res => {
+        return buildResponse(res).then(_data => {
+          return {
+            swapPrice: <SwapPrice>_data.swapPrice
+          }
+        })
+      },
+      error => {
+        throw WebrpcRequestFailedError.new({ cause: `fetch(): ${error.message || ''}` })
+      }
+    )
+  }
+
   getSwapPrices = (args: GetSwapPricesArgs, headers?: object, signal?: AbortSignal): Promise<GetSwapPricesReturn> => {
     return this.fetch(this.url('GetSwapPrices'), createHTTPRequest(args, headers, signal)).then(
       res => {

packages/passkeys/src/index.ts

@@ -38,6 +38,7 @@ export type PasskeySignerContext = {
 }
 
 export type PasskeySignMetadata = {
+  chainId?: ethers.BigNumberish
   referenceChainId?: ethers.BigNumberish
   cantValidateBehavior?: 'ignore' | 'eip6492' | 'throw'
 }
@@ -181,7 +182,7 @@ export class SequencePasskeySigner implements signers.SapientSigner {
   }
 
   async sign(digest: ethers.BytesLike, metadata: PasskeySignMetadata): Promise<ethers.BytesLike> {
-    const referenceChainId = metadata?.referenceChainId ?? this.chainId
+    const referenceChainId = metadata?.referenceChainId ?? metadata?.chainId ?? this.chainId
     const subdigest = subDigestOf(await this.getAddress(), referenceChainId, ethers.hexlify(digest))
 
     const signature = await this.doSign(digest, subdigest)

packages/sessions/src/tracker.ts

@@ -6,6 +6,7 @@ export type PresignedConfig = {
   nextConfig: commons.config.Config
   signature: string
   referenceChainId?: string
+  validateBehavior?: 'ignore' | 'throw'
 }
 
 export type PresignedConfigLink = Omit<PresignedConfig, 'nextConfig'> & { nextImageHash: string }

packages/sessions/src/trackers/local.ts

@@ -235,7 +235,12 @@ export class LocalConfigTracker implements ConfigTracker, migrator.PresignedMigr
     const savePayload = this.savePayload({ payload })
     const saveNextConfig = this.saveWalletConfig({ config: args.nextConfig })
 
-    const recovered = await v2.signature.SignatureCoder.recover(decoded, payload, this.provider)
+    const validateBehavior = args.validateBehavior ?? 'throw'
+    const recovered = await v2.signature.SignatureCoder.recover(
+      decoded,
+      payload,
+      validateBehavior === 'ignore' ? undefined : this.provider // Only validate if we are not ignoring
+    )
 
     // Save the recovered configuration and all signature parts
     const signatures = v2.signature.signaturesOf(recovered.config.tree)

packages/wallet/src/wallet.ts

@@ -433,11 +433,12 @@ export class Wallet<
   }
 
   async fillGasLimits(txs: commons.transaction.Transactionish): Promise<commons.transaction.SimulatedTransaction[]> {
-    const transaction = await resolveArrayProperties<commons.transaction.Transactionish>(txs)
-    const transactions = commons.transaction.fromTransactionish(this.address, transaction)
     const relayer = this.relayer
     if (!relayer) throw new Error('Wallet fillGasLimits requires a relayer')
 
+    const transaction = await resolveArrayProperties<commons.transaction.Transactionish>(txs)
+    const transactions = commons.transaction.fromTransactionish(this.address, transaction)
+
     const simulations = await relayer.simulate(this.address, ...transactions)
     return transactions.map((tx, i) => {
       const gasLimit = tx.gasLimit ? Number(tx.gasLimit) : simulations[i].gasLimit