Merge pull request #292 from 0xPolygonMiden/greenhat/clippy-in-tests

chore: fix clippy warnings in tests

Author: bitwalker

Makefile.toml

@@ -290,7 +290,7 @@ args = ["serve", "--open", "${CARGO_MAKE_WORKSPACE_WORKING_DIRECTORY}/docs"]
 description = "Runs clippy on the workspace"
 category = "Development"
 command = "cargo"
-args = ["clippy", "--all", "--", "-D", "clippy::all", "-D", "warnings"]
+args = ["clippy", "--all", "--all-targets", "--", "-D", "clippy::all", "-D", "warnings"]
 dependencies = ["install-clippy"]
 
 [tasks.install-clippy]

codegen/masm/src/packaging/tests.rs

@@ -105,8 +105,7 @@ fn example_package(context: &TestContext) -> Result<Arc<Package>, Report> {
     let offset_u64 = foo_ty.get(2).offset as usize;
     let foo_ty = Type::Struct(foo_ty);
     let foo_size = foo_ty.size_in_bytes();
-    let mut data = Vec::<u8>::with_capacity(foo_size);
-    data.resize(foo_size, 0);
+    let mut data = vec![0u8; foo_size];
     unsafe {
         let data_ptr_range = data.as_mut_ptr_range();
         core::ptr::write(data_ptr_range.start.byte_add(offset_u8), 1u8);

midenc-debug/src/config.rs

@@ -208,8 +208,8 @@ mod tests {
         let file = toml::from_str::<DebuggerConfig>(&text).unwrap();
         assert!(file.inputs.values().is_empty());
         assert!(file.advice_inputs.stack().is_empty());
-        assert_eq!(file.options.enable_tracing(), true);
-        assert_eq!(file.options.enable_debugging(), true);
+        assert!(file.options.enable_tracing());
+        assert!(file.options.enable_debugging());
         assert_eq!(file.options.max_cycles(), u32::MAX);
         assert_eq!(file.options.expected_cycles(), 64);
     }
@@ -226,8 +226,8 @@ mod tests {
         let file = DebuggerConfig::parse_str(&text).unwrap();
         assert!(file.inputs.values().is_empty());
         assert!(file.advice_inputs.stack().is_empty());
-        assert_eq!(file.options.enable_tracing(), true);
-        assert_eq!(file.options.enable_debugging(), true);
+        assert!(file.options.enable_tracing());
+        assert!(file.options.enable_debugging());
         assert_eq!(file.options.max_cycles(), 1000);
         assert_eq!(file.options.expected_cycles(), 64);
     }
@@ -246,8 +246,8 @@ mod tests {
         let file = DebuggerConfig::parse_str(&text).unwrap();
         assert_eq!(file.inputs.values(), &[RawFelt::new(3), RawFelt::new(2), RawFelt::new(1)]);
         assert!(file.advice_inputs.stack().is_empty());
-        assert_eq!(file.options.enable_tracing(), true);
-        assert_eq!(file.options.enable_debugging(), true);
+        assert!(file.options.enable_tracing());
+        assert!(file.options.enable_debugging());
         assert_eq!(file.options.max_cycles(), 1000);
         assert_eq!(file.options.expected_cycles(), 64);
     }
@@ -283,8 +283,8 @@ mod tests {
             file.advice_inputs.mapped_values(&digest),
             Some([RawFelt::new(1), RawFelt::new(2), RawFelt::new(3), RawFelt::new(4)].as_slice())
         );
-        assert_eq!(file.options.enable_tracing(), true);
-        assert_eq!(file.options.enable_debugging(), true);
+        assert!(file.options.enable_tracing());
+        assert!(file.options.enable_debugging());
         assert_eq!(file.options.max_cycles(), 1000);
         assert_eq!(file.options.expected_cycles(), 64);
     }